SDEI: Make dispatches synchronous
authorJeenu Viswambharan <[email protected]>
Fri, 16 Feb 2018 12:07:48 +0000 (12:07 +0000)
committerJeenu Viswambharan <[email protected]>
Thu, 21 Jun 2018 15:15:23 +0000 (16:15 +0100)
commitcdb6ac94ecb3c4caa784cd4d7580cf6252146196
treeca75b64e905639641e9cd00bc0d07513364afe9e
parente7b9473e1591d4ab375a95ebbb9256adfe9d4670
SDEI: Make dispatches synchronous

SDEI event dispatches currently only sets up the Non-secure context
before returning to the caller. The actual dispatch only happens upon
exiting EL3 next time.

However, for various error handling scenarios, it's beneficial to have
the dispatch happen synchronously. I.e. when receiving SDEI interrupt,
or for a successful sdei_dispatch_event() call, the event handler is
executed; and upon the event completion, dispatcher execution resumes
after the point of dispatch. The jump primitives introduced in the
earlier patch facilitates this feature.

With this patch:

  - SDEI interrupts and calls to sdei_dispatch_event prepares the NS
    context for event dispatch, then sets a jump point, and immediately
    exits EL3. This results in the client handler executing in
    Non-secure.

  - When the SDEI client completes the dispatched event, the SDEI
    dispatcher does a longjmp to the jump pointer created earlier. For
    the caller of the sdei_dispatch_event() in particular, this would
    appear as if call returned successfully.

The dynamic workaround for CVE_2018_3639 is slightly shifted around as
part of related minor refactoring. It doesn't affect the workaround
functionality.

Documentation updated.

NOTE: This breaks the semantics of the explicit dispatch API, and any
exiting usages should be carefully reviewed.

Change-Id: Ib9c876d27ea2af7fb22de49832e55a0da83da3f9
Signed-off-by: Jeenu Viswambharan <[email protected]>
bl31/bl31.mk
docs/plantuml/sdei_explicit_dispatch.puml
docs/plantuml/sdei_explicit_dispatch.svg
docs/sdei.rst
include/services/sdei.h
services/std_svc/sdei/sdei_dispatch.S [new file with mode: 0644]
services/std_svc/sdei/sdei_intr_mgmt.c
services/std_svc/sdei/sdei_private.h